Repository navigation
ci(timed-run): a core plan gives the world, the launcher and the load drivers their own cores (#2507) - #2573
Merged
Merged
Conversation
… drivers their own cores (#2507) The cores input (world=N or world=N,launcher=M) splits the runner's physical cores; the launcher is pinned apart as the world is, a plan that does not fit is refused at the start gate, and each run records each group's busy share. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
genekogan
marked this pull request as ready for review
November 16, 2026 07:50
Contributor
Proof check:
|
| Check | Status | Detail |
|---|---|---|
| problem statement | ok | present |
| linked issue | ok | #2507 |
Acceptance criteria
| Criterion | Status | Evidence | |
|---|---|---|---|
| [x] | A1 cores is accepted, validated and recorded; a plan that does not fit |
met | the test core plan (#2507): cores is accepted ... in node --test .github/scripts/timed-run.test.mjs -> 17 pass, 0 fa |
| [x] | A2 One viewers --viewers 50 run with cores: world=2,launcher=1 shows |
met | run |
| [x] | A3 Default behaviour (no cores input) is unchanged: the same split as t |
met | run |
Proof links: 0 video, 0 image, no proof.json.
Updated on every edit, push, label and review. How to fill it: .claude/skills/journal/SKILL.md. T3-T4 also need the maintainer's sign-off (tools/proof/gate.mjs). A maintainer can waive with the proof:waived label.
genekogan
enabled auto-merge
November 16, 2026 08:31
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 16, 2026
Member
Author
|
Merge queue: this PR left the queue without merging (reason: Fix it and add |
genekogan
enabled auto-merge
November 16, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the three-core timed runners,
timed-run.mjsgives the world 2 physical cores and puts the launcher and the load driver together on the third. A scaling run therefore cannot tell "the world is at its limit" from "the bench is". Step 0 (on the issue) read 0.077 to 0.095 cores for the launcher and driver together at 200 viewers, which scales to about 1.9 to 2.4 cores at 5,000, so the shared core would become the limit. Closes #2507.Acceptance
coresis accepted, validated and recorded; a plan that does not fit is refused at the start gate (unit test intimed-run.test.mjs) — evidence: the testcore plan (#2507): cores is accepted ...innode --test .github/scripts/timed-run.test.mjs-> 17 pass, 0 fail. On a real runner, run https://github.com/soulsimulation/souls/actions/runs/43823296471 (cores=world=2,launcher=1, viewers 50) was refused at its Start load step, before any load sampling, withthe core plan world=2,launcher=1 needs 4 physical cores (at least one for the load drivers); this runner has 3 of its own. The plan is recorded in the receipt asinputs.coresandcpuSplit.plan.viewers --viewers 50run withcores: world=2,launcher=1shows the launcher pinned apart from the driver in the receipt — evidence: run https://github.com/soulsimulation/souls/actions/runs/43823299362, receipttimed-run.jsonruns[0].cpuSplit:plan world=1,launcher=1,layout 1+1+1, world0,24, launcher1,25, load2,26,launcherProcesses 1withlauncherAllowed ["1,25"]read back,worldAllowed ["0,24"]. Busy share (mean / busiest 5 s): world 0.348 / 0.772, launcher 0.031 / 0.054, load 0.029 / 0.142. Start load: own cores 0.013. The runners have 3 physical cores, so this ran the smaller plan the issue's Risks section allows (see Deviations).coresinput) is unchanged: the same split as today in the receipt — evidence: run https://github.com/soulsimulation/souls/actions/runs/43823302599, nocores: receiptcpuSplitlayout 2+1,physicalCores 3, world9,33,10,34(the first two physical cores), load11,35,worldAllowed ["9-10,33-34"]. This is the same shape as the pre-change receipt of run 43781046865 (2+1, world the first two cores, load the third). The only addition isbusy: world 0.233 / 0.446, load 0.052 / 0.151. Noplanorlauncherkey, andinputshas nocoreskey. The default path ofsplitCoresis unchanged, which the unit test asserts (splitCores(x, smt, null)deep-equalssplitCores(x, smt)).Proof
Tier: T0
What changed
timed-run.yml: a newcoresinput,world=Norworld=N,launcher=Mphysical cores. It is passed on asINPUT_CORES.timed-run.mjs:parseInputsaccepts a plan for the split commands only and validates it (parseCorePlan).splitCores(own, siblingsOf, plan)gives the world the first N cores, the launcher the next M and the load drivers the rest (at least one). A plan that does not fit is refused with a plain message. Without a plan the split is exactly as before.pinWorldsalso pins each launcher process (isLauncher:tools/world-launcher/launcher.mjs) onto the launcher's cores. A world the launcher starts is still moved on to the world's cores./proc/stat.cpuSplit.busy.<group>records{ mean, peak5s }.Deviations from the design
cores: world=2,launcher=1. Everysouls-timedrunner gives a job 3 physical cores, and that plan needs 4 (one is left for the load drivers), so the gate refuses it there (run 43823296471, the A1 evidence). A2 ranworld=1,launcher=1, the smaller plan the issue's Risks section names, until a wide runner exists. The amended declaration was posted on the issue before any run.docs/testing.md(the timed-run section). The timed-run section is in factdocs/testing/playtests.md("Timed runs"), which the workflow's header names. The docs change went there (5 lines).Self-audit
node --test .github/scripts/timed-run.test.mjs-> 17 pass, 0 failnode tools/proof/tier.mjs-> T0node .github/scripts/guards.mjs scrub --base origin/main-> 0 problems/proc/statevery 5 s in the control process. That is negligible, and it runs on the job's control process, not in the measured groups' pinned processes.cpuSplit.busy. No consumer parsescpuSplitstrictly.docs/testing/playtests.md"Timed runs": thecoresinput, the refusal and the recorded shares.Changelog
Label
no-changelog: CI tooling only.Outside Touches
docs/testing/playtests.md(5 lines; it holds the timed-run section that Touches means, see Deviations)Time
Started 07:18 UTC. Took about 32 min wall clock (07:18 to 07:50 UTC), of which about 25 min was waiting on the runners, so about 7 min of work against a ceiling of 2 h (runner waits not counted).
Risk
The only path that changes without a plan is the extra
/proc/statsampling and thebusyfield. If it misbehaves, a timed run fails at its Run step and someone dispatching would see it at once. To roll back, revert this PR.🤖 Generated with Claude Code